[Bug 1318381] Review Request: gtengine - Geometric Tools Engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318381



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
rm -rf $RPMBUILDROOT is unnecessary.

Hm, what is the "touch $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2" for?

ln -sf %{_libdir}/libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2
...
I think this should be
ln -s libgtengine.so.2.0 ${buildroot}%{_libdir}/libgtengine.so.2
ln -s libgtengine.so.2 ${buildroot}%{_libdir}/libgtengine.so

(Links should be relative.)

+ license is acceptable (Boost)
+ license file is present, %license is used
+ name is OK
+ latest version
+ scriptlets look sane
+ provides/requires look fine
+ fedora-review has nothing interesting to say
+ devel subpackage is split out correctly

rpmlint:
gtengine.i686: W: spelling-error %description -l en_US multithreading ->
multitasking
gtengine.i686: W: no-documentation
gtengine.src: W: spelling-error %description -l en_US multithreading ->
multitasking
gtengine-devel.i686: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
All OK.

So the only thing is the strange installation commands.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]