[Bug 1318988] Review Request: java-1.8.0-openjdk-aarch32 - OpenJDK AArch32 porting project preview release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318988



--- Comment #19 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> ---
(In reply to jiri vanek from comment #14)
> (In reply to Severin Gehwolf from comment #8)
> > /builddir/build/BUILD/java-1.8.0-openjdk-aarch32-1.8.0.tip-3.tip.fc24.arm/
> > openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o
> > precompiled.hpp.gch
> > 
> > The build you are linking above and the SRPM provided build the Zero
> > interpreter from the aarch32 sources, *not* the aarch32 template interpreter!
> 
> 
> Indeed. And thats for now intentional. I can fix it now, during review,
> after review or anytime  in lifecycle.

Please propose a spec for review which does what it will ultimately do. The
whole point of this extra package is the aarch32 template interpreter. So yes,
please change this to use the template interpreter and show that it builds and
works reasonably.

> My target was to fix it once it will be building itself.

For the sake of this review, I'd be willing to accept that it doesn't yet build
itself. That is something which can be fixed once the review is done. It should
at least work reasonably, though.

> (In reply to Severin Gehwolf from comment #9)
> 
> > [!] Please remove FIXME comment:
> > ----
> > #FIXME
> > #    --with-jvm-variants=core \
> > ----

Fair enough. A comment could have said so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]