https://bugzilla.redhat.com/show_bug.cgi?id=1312015 --- Comment #24 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Raphael Groner from comment #22) > Okay, we're getting closer to an approval. Thanks for your patience. Thanx for YOURS patience. > > . We need 'BuildRequires: ant java-devel jpackage-utils'. But do not add > something of that as Requires in javadoc subpackage, means remove 'Requires: > jpackage-utils' and let rpmbuild care about automatically generated > dependencies. We'll see success in the f-r log. > https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires Oh. Sure. This is/was already fixed in v4. > > > - Packages have proper BuildRequires/Requires on jpackage-utils > … > > - Javadoc subpackages should not have Requires: jpackage-utils > > Note: jpackage-utils requires are automatically generated by the > > buildsystem > > See: https://fedoraproject.org/wiki/Packaging:Java > same. > > . Hint: You can use a special feature of GitHub to generate patches, in > combination with rpm macro expansion. Also use %autosetup. > https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section: > _.25autosetup_command As you wish, done. > > URL: https://github.com/judovana/%{srcname} > Source0: > %{url}/releases/tag/%{srcname}-2.2/%{srcname}-%{srcname}-%{version}.tar.gz > # javadocFixes > Patch0: %{url}/commit/853285f3105506b860c762f534e1a7c2733a2c61.patch > # fixed license > Patch1: %{url}/commit/7d0c410d9ef215499f4fa4fb67e9a105f0a95ba7.patch > > %prep > # use autosetup to untar source and apply above patches > %autosetup -p1 -n%{srcname}-%{srcname}-%{version} > # remove all %patch lines > > > Please upload an updated spec file. I get an old one for v3. Spec URL: https://jvanek.fedorapeople.org/offlinesearch/v5/javadocofflinesearch.spec SRPM URL: https://jvanek.fedorapeople.org/offlinesearch/v5/javadocofflinesearch-2.2-1.fc23.src.rpm and ... https://jvanek.fedorapeople.org/offlinesearch/v5/bins/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review