[Bug 1312015] Review Request: javadocofflinesearch - Tool for offline searching in your docs via browser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1312015



--- Comment #22 from Raphael Groner <projects.rg@xxxxxxxx> ---
Okay, we're getting closer to an approval. Thanks for your patience.

. We need 'BuildRequires: ant java-devel jpackage-utils'. But do not add
something of that as Requires in javadoc subpackage, means remove 'Requires:
jpackage-utils' and let rpmbuild care about automatically generated
dependencies. We'll see success in the f-r log.
https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires

> - Packages have proper BuildRequires/Requires on jpackage-utils
…
> - Javadoc subpackages should not have Requires: jpackage-utils
>  Note: jpackage-utils requires are automatically generated by the
>  buildsystem
>  See: https://fedoraproject.org/wiki/Packaging:Java


. Hint: You can use a special feature of GitHub to generate patches, in
combination with rpm macro expansion. Also use %autosetup.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25autosetup_command

URL:            https://github.com/judovana/%{srcname}
Source0:       
%{url}/releases/tag/%{srcname}-2.2/%{srcname}-%{srcname}-%{version}.tar.gz
# javadocFixes
Patch0:         %{url}/commit/853285f3105506b860c762f534e1a7c2733a2c61.patch
# fixed license
Patch1:         %{url}/commit/7d0c410d9ef215499f4fa4fb67e9a105f0a95ba7.patch

%prep
# use autosetup to untar source and apply above patches
%autosetup -p1 -n%{srcname}-%{srcname}-%{version}
# remove all %patch lines


Please upload an updated spec file. I get an old one for v3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]