[Bug 988667] Review Request: valadoc - Documentation tool for the vala project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=988667



--- Comment #19 from Raphael Groner <projects.rg@xxxxxxxx> ---
Again, some general advice:

. You must use '%license COPYING', remove '%doc COPYING' instead.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

. There's no license for the sub packages (devel & data), make them 'Require:
%{name}%{?_isa} = %{version}-%{release}'.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing 

. I guess you want also add 'Require: %{name}-data%{?_isa} =
%{version}-%{release}' into main package, or data could be merged completely
into main, why another sub package? At least, add 'BuildArch: noarch' into data
subpackage.
https://fedoraproject.org/wiki/Packaging:Guidelines#Noarch_with_unported_dependencies

. Remove 'Group: Development/Tools', it's deprecated.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview

. Maybe simplify/improve the removal of .la and .a files:
find %{buildroot}%{_libdir} -name \*.la -print -delete
rm -fv %{buildroot}/%{_libdir}/*.a

. You must provide a proper %changelog with at least some intial entry.
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]