[Bug 1304632] Review Request: libmlx5 - Mellanox Connect-IB InfiniBand HCA Userspace Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1304632



--- Comment #8 from Honggang LI <honli@xxxxxxxxxx> ---
(In reply to Neil Horman from comment #6)

> [!]: Final provides and requires are sane (see attachments).
> Is this:
> Provides: libibverbs-driver.%{_arch}
> Being unversioned and without a driver name attached, it seems useless.

It is necessary. All RDMA user space drivers, for example, libcxgb3, libcxgb4,
libmlx4, libmlx5 provides this. The libibverbs package dose not provide any
specific driver for RDMA HCAs. The corresponding user space drivers, such as,
libmlx5 dose.

> 
> ===== EXTRA items =====
> 
> Generic:
> [!]: Rpmlint is run on all installed packages.
>      Note: Mock build failed
>      See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint

This is an fedora-review tool bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1322166#c0

> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

Those files context is identical. But they are in different format. It seems
the original spec file had been created in Windows machine. Anyway, I recreated
the src file and spec file.

honli@dhcp47-85:~/mlx5/rpm$ file libmlx5.spec.download_from_url
libmlx5.spec.from_the_src_rpm
libmlx5.spec.download_from_url: ASCII text, with CRLF line terminators
libmlx5.spec.from_the_src_rpm:  ASCII text


> /home/nhorman/1304632-libmlx5/results/libmlx5-debuginfo-1.0.2-2.fc25.x86_64.
> rpm
> /home/nhorman/1304632-libmlx5/results/libmlx5-debuginfo-1.0.2-2.fc25.x86_64.
> rpm

As you see, duplicated debuginfo packages.

> ERROR: Command failed. See logs for output.

> I think if you fix up that Provides, or explain it, we will be good to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]