https://bugzilla.redhat.com/show_bug.cgi?id=988667 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? | --- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- In order of importance: - Source0: https://git.gnome.org/browse/valadoc/snapshot/valadoc-valac-%{version}.tar.xz - %{_libdir}/libvaladoc.so should be in -devel, not in the main package - there's no license file listed in %files - why do you delete the single .mo file? A comment in the spec file would be nice. - URL seems wrong. It should point to the project page for valadoc (see comment #11), and not the website containing generated docs. Current URL is useful though, it might be worth putting it in %description ("\nDocumentation for various projects written in vala can be found at <URL>.") - %description has an empty line at the top - %description should be extended a bit to say something that valadoc extracts documentation from the source code (or whatever, I'm just guessing here). - %post/%postun scriptlets require shell unnecessarily, %post -p /sbin/ldconfig is better [https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Shared_libraries]. - %{buildroot} is preferred to $RPM_BUILD_ROOT and it's considered bad style to use both - You can use %make_build instead of make %{?_smp_mflags} and %make_install instead of make install DESTDIR=%{buildroot}. More consise. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review