https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #12 from Honggang LI <honli@xxxxxxxxxx> --- Hello, Dennis http://people.redhat.com/honli/.b187328c893321f3baa62cc5ef46f5d1/ I uploaded my review result into this http dir. Please fix the obsoleted m4s macros in upstream git repo and recreate the spec and src. http://people.redhat.com/honli/.b187328c893321f3baa62cc5ef46f5d1/review.txt ============================================= Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools .................. AutoTools: Obsoleted m4s found ------------------------------ AM_PROG_LIBTOOL found in: libhfi1-0.5/configure.in:63 AM_CONFIG_HEADER found in: libhfi1-0.5/configure.in:61 ============================================= What I modified based on your spec. 1) rename libhfi1verbs as libhfi1, as we had import it into rhel-7.2 with the name libhfi1. If Fedora and RHEL-7 have different names for this package. It will be an trouble. https://bugzilla.redhat.com/show_bug.cgi?id=1251634 2) replace '%define' with '%global' 3) BuildRequires: libibverbs-devel >= 1.2.0 We had update libibverbs to latest upstream v1.2.0 for Fedora. 4) replace '-devel' package with '-static' a) There is a *.a file, it should be packaged with -static package, not -devel package. b) All other verbs user space drivers have a static package instead a -devel package. 5) make %{?_smp_mflags} It seems there is a typo in your spec file. 6) As this package is licensed by multiple licenses, so add comment in spec file as required. 7) Add changelog as I said in comment #1. Please check your name. thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review