[Bug 1318969] Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318969

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(B::Hooks::OP::Check) >= 0.19
      1 perl(B::Utils) >= 0.19
      1 perl(DynaLoader)
      1 perl(Scalar::Util)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
$ rpm -qp --requires
perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
      1 perl-devel(x86-64)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 perl(B::Hooks::OP::Check::EntersubForCV) = 0.09
      1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
      1 perl-B-Hooks-OP-Check-EntersubForCV(x86-64) = 0.09-13.fc25
$ rpm -qp --provides
perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq
-c
      1 perl(B::Hooks::OP::Check::EntersubForCV::Install::Files)
      1 perl-B-Hooks-OP-Check-EntersubForCV-devel = 0.09-13.fc25
      1 perl-B-Hooks-OP-Check-EntersubForCV-devel(x86-64) = 0.09-13.fc25
Binary provides are Ok.

$ rpmlint ./perl-B-Hooks-OP-Check-EntersubForCV*
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error Summary(en_US)
entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error %description -l
en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error Summary(en_US)
entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error %description -l
en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: only-non-binary-in-usr-lib
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 6 warnings.

Rpmlint is ok

BuildRequires
FIX: Please add BRs
 * coreutils - spec file line 54
 * perl(Module::Install::Makefile) - define makemaker_args used in Makefile.PL
(line 27)

Please correct all 'FIX' issues

Otherwise the package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]