https://bugzilla.redhat.com/show_bug.cgi?id=1321473 --- Comment #9 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- (In reply to Raphael Groner from comment #8) > (In reply to Igor Gnatenko from comment #7) > > 1. Regarding bundled waf - I would like to see bug for upstream for updating > > their bundled version of waf (then we can just remove waf, waflib from > > source tree) > > Good point. I'll do so. > > > 2. I would like to see dependencies in pkgconfig() format. It's more easy to > > maintain. > > BuildRequires: pkgconfig(gdk-3.0) > > pkgconfig is not available for libgee, so I decided to skip. [brain@x1carbon bin]$ sudo dnf repoquery --provides libgee-devel Last metadata expiration check: 1:15:36 ago on Tue Mar 29 10:53:47 2016. libgee-devel = 0.18.0-3.fc24 libgee-devel(x86-32) = 0.18.0-3.fc24 libgee-devel(x86-64) = 0.18.0-3.fc24 pkgconfig(gee-0.8) = 0.18.0 > > $ LC_ALL=C dnf whatprovides 'pkgconfig(libgee)' > Last metadata expiration check: 0:00:11 ago on Tue Mar 29 11:44:01 2016. > Error: No Matches found > > > 3. Requires: libgee-devel > > I think you missed %{?_isa} > > What do you mean? Requires: libgree-devel%{?_isa} > > > 4. BuildRequires: desktop-file-utils. The same as in point 2. > > BuildRequires: /usr/bin/desktop-file-validate > > Not true. It's to prefer to give direct package name. > > > 5. Header and symlink for soname library etc. > > Development files and headers required ... > > It should be more descriptive > > Please give a suggestion how to improve. > > > 6. I'm not sure if we should include "diodon-test" in package. What is it > > for? > > [brain@x1carbon bin]$ LD_LIBRARY_PATH=../lib64/ ./diodon-test > > /TestImageClipboardItem/test_image_clipboard_item_new_with_payload: ** > > Message: testcase.vala:140: Got exception while excuting test: Failed to > > open file '/builddir/build/BUILD/diodon-1.4.0/tests/data/Diodon-64x64.png': > > No such file or directory > > FAIL > > Aborted (core dumped) > > > > yes, remove it. > > Okay. It's installed from wscript, so I did not touch. > > > 7. %{_libdir}/girepository-1.0/*.typelib > > typelib should go to main package, not -devel. Because it is used in runtime > > by other GObject-based applications. > > Okay. I wasn't sure how to handle. > > > Once this will be fixed - I will approve ;) > > Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review