https://bugzilla.redhat.com/show_bug.cgi?id=1321473 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #7 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- 1. Regarding bundled waf - I would like to see bug for upstream for updating their bundled version of waf (then we can just remove waf, waflib from source tree) 2. I would like to see dependencies in pkgconfig() format. It's more easy to maintain. BuildRequires: pkgconfig(gdk-3.0) 3. Requires: libgee-devel I think you missed %{?_isa} 4. BuildRequires: desktop-file-utils. The same as in point 2. BuildRequires: /usr/bin/desktop-file-validate 5. Header and symlink for soname library etc. Development files and headers required ... It should be more descriptive 6. I'm not sure if we should include "diodon-test" in package. What is it for? [brain@x1carbon bin]$ LD_LIBRARY_PATH=../lib64/ ./diodon-test /TestImageClipboardItem/test_image_clipboard_item_new_with_payload: ** Message: testcase.vala:140: Got exception while excuting test: Failed to open file '/builddir/build/BUILD/diodon-1.4.0/tests/data/Diodon-64x64.png': No such file or directory FAIL Aborted (core dumped) yes, remove it. 7. %{_libdir}/girepository-1.0/*.typelib typelib should go to main package, not -devel. Because it is used in runtime by other GObject-based applications. Once this will be fixed - I will approve ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review