Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-Number-Delta - Compare the difference between numbers against a given tolerance https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245501 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-25 01:13 EST ------- Sorry about the delay; a storm took out my Internet connection for a while. * source files match upstream: 9cd18d89bde4333f9f9b77668ef03e6e20d8ee5675c2ab1b216c7323419a320e Test-Number-Delta-1.03.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64) * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Test::Number::Delta) = 1.03 perl-Test-Number-Delta = 1.03-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(Test::Builder) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=13, Tests=69, 1 wallclock secs ( 0.48 cusr + 0.20 csys = 0.68 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. (Heck, the license file alone is bigger than the rest of the package.) * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review