Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: andutteye-client - Andutteye Software Suite Monitoring agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211319 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-24 11:39 EST ------- Some remarks for 2.3-11: * First, rpmlint: --------------------------------------------------- W: andutteye-client spurious-executable-perm /usr/share/man/man1/andutteyed.1.gz W: andutteye-client spurious-executable-perm /usr/share/doc/andutteye-client-2.3/README E: andutteye-client non-standard-uid /var/cache/andutteye andutteye E: andutteye-client non-standard-gid /var/cache/andutteye andutteye W: andutteye-client spurious-executable-perm /usr/share/doc/andutteye-client-2.3/LICENSE E: andutteye-client non-standard-uid /usr/bin/andutteyed andutteye E: andutteye-client non-standard-gid /usr/bin/andutteyed andutteye W: andutteye-client spurious-executable-perm /usr/share/man/man1/postandutteye.1.gz E: andutteye-client non-standard-uid /var/log/andutteye andutteye E: andutteye-client non-standard-gid /var/log/andutteye andutteye E: andutteye-client non-standard-uid /etc/andutteye/andutteyed.conf andutteye E: andutteye-client non-standard-gid /etc/andutteye/andutteyed.conf andutteye E: andutteye-client incoherent-logrotate-file /etc/logrotate.d/andutteyed E: andutteye-client non-standard-uid /usr/bin/andutteye-api-linux.pl andutteye E: andutteye-client non-standard-gid /usr/bin/andutteye-api-linux.pl andutteye E: andutteye-client non-standard-uid /usr/bin/postandutteye andutteye E: andutteye-client non-standard-gid /usr/bin/postandutteye andutteye W: andutteye-client dangerous-command-in-%postun userdel W: andutteye-client service-default-enabled /etc/init.d/andutteyed E: andutteye-client incoherent-subsys /etc/init.d/andutteyed andutteyed} W: andutteye-client service-default-enabled /etc/init.d/andutteyed W: andutteye-client incoherent-init-script-name andutteyed ------------------------------------------------------ - While many of these rpmlint can be ignored in my opinion, some of them should be fixed. SUMMARY: - Please fix the permission of the documents and man files (all these files should have 0644 permission) - Why should the 3 scripts under /usr/bin should have (owner:group) = (andutteye:andutteye)? These scripts are not setuid'ed or setgid'ed, so the euid/egid of the process using these scripts are the same as the real uid/gid, so anyway it should be okay with (owner:group) = (root:root) - Does andutteye user edit/modify the config file /etc/andutteye/andutteyed.conf when andutteyed daemon is running or something else happens? If the config is to be editted by sysadmin anyway, then the (owner:group) of this conf file should be okay with (root:root). - Please remove /usr/sbin/userdel, /usr/sbin/groupdel completely. Current Fedora policy is that "userdel groupdel must not be done automatically by rpm and these should be done manually by sysadmin". - Currently when andutteye-client is installed, it automatically enables andutteyed service on level 345 as -------------------------------------------------- # chkconfig: 345 90 10 -------------------------------------------------- , which is bad. sysadmin should manually set the level where andutteyed should be enabled. Please change to -------------------------------------------------- # chkconfig: - 90 10 -------------------------------------------------- * groupadd/useradd - Please consider if the failure of groupadd or useradd command should be ignored (i.e. consider if -------------------------------------------------- groupadd ..... || : -------------------------------------------------- is okay... You can refer to the suggestion by Ville: http://fedoraproject.org/wiki/PackagingDrafts/UsersAndGroups ) - And add the proper Requires(pre).. etc (Please check: the section "Services" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) * Macros - For directory where services scripts are to be installed, please use %_initrddir (= /etc/rc.d/init.d), not /etc/init.d - /usr/sbin -> %_sbindir * sourced file - Well, %{_sysconfdir}/profile.d/aemonitoring.sh is source'd also by normal user (like /etc/profile.d/less.sh). Is it needed? If not, please move this file to %{_sysconfdir}/andutteye/, for example. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review