[Bug 1132661] Review Request: atom - Atom editor from github

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1132661



--- Comment #20 from Milan Bouchet-Valat <nalimilan@xxxxxxx> ---
(In reply to Mohammed Safwat from comment #19)
> I tried scratch builds with koji and got stuck at errors during build like
> the ones found here
> http://koji.fedoraproject.org/koji/taskinfo?taskID=13462846.
> 
> The build steps for atom seem to contact github to grab some stuff related
> to npm and grunt(; I'm not an expert but that's what the logs are telling I
> assume). I guess koji build servers confine building packages inside a
> sandbox that wouldn't allow network access to external servers like
> github(and I don't blame this setup).
Indeed, Fedora packages must be built without network access, to ensure they
can be reliably created only from the SRPM.

> Now I'm left with installing npm package for F24 manually as Milan suggested
> or building from a private recent version of npm(created during build) as
> Helber suggested.
While this is useful for development, this isn't a final solution, as the
official package will have to build without Internet access.

Looking at the logs from [1], it seems to me you're going to have to package
grunt-coffeelint, grunt-babel, grunt-lesslint, grunt-standard, grunt-cson,
grunt-contrib-coffee, grunt-shell, grunt-download-electron,
grunt-electron-installer and grunt-peg. While the list might seem scary, it
should be a straightforward and quite repetitive task, and there are already a
load of nodejs-grunt-* RPM packages in Fedora. See instructions at
https://fedoraproject.org/wiki/Packaging:Node.js. If you file a new bug for
these packages, you'll probably get help from people who have already packaged
hundreds of RPMs like that.

1:
https://copr-be.cloud.fedoraproject.org/results/helber/atom/fedora-rawhide-x86_64/00170302-atom/build.log.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]