[Bug 1265685] Review Request: sylfilter - A generic message filter library and command-line tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1265685

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #40 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
In comments and changelog percent signs must be escaped by doubling:
- removes %description to after Requires
→
- move %%description after Requires

%files
...
%{_libdir}/libsylfilter.*
%{_libdir}/libsylfilter.so.*

Everything which is matched by the second glob is also matched by the first
glob. You only need the second line.

And as discussed before: there's no need to say "addresses comments of Zbigniew
Jędrzejewski-Szmek". I understand that the intent is to give due credit, but we
try to keep changelogs short. You can just remove those lines.

Package is APPROVED. Please fix up those minor issues in the initial upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]