https://bugzilla.redhat.com/show_bug.cgi?id=1310092 --- Comment #21 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in cryptobone See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions This is a special case I think we're good here. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text This is due to a Fedora specific guideline to put licenses in /usr/share/license instead of /usr/share/doc to reduce install size for space limited targets like arm. Might be best to remove the license stuff from your makefile and use relative paths instead. - cryptobone.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib/cryptobone/libcl.so.3.4.3 $ rpmlint -I missing-call-to-setgroups-before-setuid missing-call-to-setgroups-before-setuid: This executable is calling setuid and setgid without setgroups or initgroups. There is a high probability this means it didn't relinquish all groups, and this would be a potential security issue to be fixed. Seek POS36-C on the web for details about the problem. - Some files are licensed MIT: MIT/X11 (BSD like) ------------------ cryptobone-1.0.1/src/cryptoboned/b64.c cryptobone-1.0.1/src/cryptoboned/b64.h cryptobone-1.0.1/src/openpgp/b64.c cryptobone-1.0.1/src/openpgp/b64.h I think just updating your license tag to "BSD and MIT" should be good enough here. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "GPL (v3 or later)", "Unknown or generated", "BSD (4 clause)". 12 files have unknown license. Detailed output of licensecheck in /home/build/fedora- review/1310092-cryptobone/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/cryptobone [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/init.d, /usr/share/icons/default, /usr/share/doc/cryptobone\ Do we need the init.d file since we have a systemd service file? I think we can ignore all but /usr/share/doc/cryptobone which can be added as: %dir %{_docdir}/cryptobone in %files [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ x: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cryptobone-1.0.1-6.fc25.x86_64.rpm cryptobone-1.0.1-6.fc25.src.rpm cryptobone.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib/cryptobone/libcl.so.3.4.3 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/sudogetuser 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/sudogetuser 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cbcontrol 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cbcontrol 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/createmasterkey 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/createmasterkey 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/keys 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/cryptobone 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cryptoboned 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cryptoboned 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/getlocalsecret 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/getlocalsecret 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/bin 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/getIP 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/getIP 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/rc.local 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/rc.local 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cbcontrol.functions 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cbcontrol.functions 700 cryptobone.x86_64: E: non-readable /etc/init.d/cryptoboned 700 cryptobone.x86_64: E: non-standard-executable-perm /etc/init.d/cryptoboned 700 cryptobone.x86_64: W: dangerous-command-in-%preun rm cryptobone.x86_64: W: dangerous-command-in-%postun rm cryptobone.x86_64: E: postin-without-chkconfig /etc/init.d/cryptoboned cryptobone.x86_64: E: preun-without-chkconfig /etc/init.d/cryptoboned cryptobone.x86_64: W: service-default-enabled /etc/init.d/cryptoboned cryptobone.x86_64: W: service-default-enabled /etc/init.d/cryptoboned cryptobone.x86_64: E: subsys-not-used /etc/init.d/cryptoboned cryptobone.src:1: E: hardcoded-library-path in %{_prefix}/lib/%{name} cryptobone.src:54: W: setup-not-quiet cryptobone.src:116: W: macro-in-comment %{cryptobonedir} 2 packages and 0 specfiles checked; 27 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: cryptobone-debuginfo-1.0.1-6.fc25.x86_64.rpm cryptobone-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- cryptobone.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib/cryptobone/libcl.so.3.4.3 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/getIP 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/getIP 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/getlocalsecret 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/getlocalsecret 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/sudogetuser 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/sudogetuser 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/bin 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cbcontrol.functions 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cbcontrol.functions 700 cryptobone.x86_64: E: non-readable /etc/init.d/cryptoboned 700 cryptobone.x86_64: E: non-standard-executable-perm /etc/init.d/cryptoboned 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/cryptobone 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/rc.local 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/rc.local 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone/keys 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cryptoboned 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cryptoboned 700 cryptobone.x86_64: E: non-standard-dir-perm /usr/lib/cryptobone 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/cbcontrol 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/cbcontrol 700 cryptobone.x86_64: E: non-readable /usr/lib/cryptobone/createmasterkey 700 cryptobone.x86_64: E: non-standard-executable-perm /usr/lib/cryptobone/createmasterkey 700 cryptobone.x86_64: W: dangerous-command-in-%preun rm cryptobone.x86_64: W: dangerous-command-in-%postun rm cryptobone.x86_64: E: postin-without-chkconfig /etc/init.d/cryptoboned cryptobone.x86_64: E: preun-without-chkconfig /etc/init.d/cryptoboned cryptobone.x86_64: W: service-default-enabled /etc/init.d/cryptoboned cryptobone.x86_64: W: service-default-enabled /etc/init.d/cryptoboned cryptobone.x86_64: E: subsys-not-used /etc/init.d/cryptoboned cryptobone-debuginfo.x86_64: E: debuginfo-without-sources 2 packages and 0 specfiles checked; 27 errors, 4 warnings. Requires -------- cryptobone (rpmlib, GLIBC filtered): /bin/bash /bin/ksh /bin/sh /usr/bin/python MTA base64 bash cryptsetup fetchmail ksh libbsd.so.0()(64bit) libbsd.so.0(LIBBSD_0.0)(64bit) libc.so.6()(64bit) libcl.so.3.4.3()(64bit) libdl.so.2()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) nmap openssh openssh-askpass python rtld(GNU_HASH) socat systemd tkinter Provides -------- cryptobone: application() application(cryptobone.desktop) bundled(libcl.so) cryptobone cryptobone(x86-64) libcl.so.3.4.3()(64bit) Source checksums ---------------- https://crypto-bone.com/release/source/cryptobone-1.0.1.tar.gz : CHECKSUM(SHA256) this package : bf01ab08a171ad433769119c461a5ef4f856e17c58ba5605eb17ef3d507db9b9 CHECKSUM(SHA256) upstream package : bf01ab08a171ad433769119c461a5ef4f856e17c58ba5605eb17ef3d507db9b9 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1310092 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review