[Bug 1312015] Review Request: javadocofflinesearch - Tool for offline searching in your docs via browser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1312015



--- Comment #5 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to jiri vanek from comment #4)
…
> This advice do not sound right
> I'm packing the lone jar to %{_javadir}
>   cp dist/%{name}.jar $RPM_BUILD_ROOT/%{_javadir}
> exactly as the guidelines says. Have I missed osmthing more?
> Of ocuorse I canuse install insted of cp for this file.

Look into build.xml about build of jar file.
https://github.com/judovana/JavadocOfflineSearch/blob/master/build.xml#L103

> Same for javadoc - it is placed right. And Wihtout that manual copy, no
> javadoc appeared.

Javadoc is not the topic.

> As fr "assembly" in your sugestion. Where did you get that? The ant run by
> default do not run assembly target in build file.
> Also this generated file would be against all guidelines (it is containing
> budled lucene pdfbox .. and all deps)

I fail to see where any jar files get bundled.

> So I would really stay with dist.

I would not recommend to use a completely different build logic. Guidelines
clearly state to use build process of upstream, whereever possible. I agree
about missing part for installation at upstream, so we obviously have to patch
that but not seamlessly the whole build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]