Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fityk-0.8.1 - curve-fitting program for X-Y data https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245485 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-24 07:07 EST ------- Created an attachment (id=157707) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=157707&action=view) mock build log of fityk 0.8.1-16.1 Umm... (In reply to comment #4) > The suggestions about the icon and tips file seems incorrect. - What is strange is that the build log actually says: ---------------------------------------------------------- /usr/bin/install -p -m 644 'tips.txt' '/var/tmp/fityk-0.8.1-16.1-buildroot/usr/share/fityk/tips.txt' make[4]: Leaving directory `/builddir/build/BUILD/fityk-0.8.1/src/wxgui' ...... /usr/bin/install -p -m 644 'fityk.png' '/var/tmp/fityk-0.8.1-16.1-buildroot/usr/share/pixmaps/fityk.png' make[2]: Leaving directory `/builddir/build/BUILD/fityk-0.8.1' ...... ----------------------------------------------------------- So: - Actually fityk.png is installed. And ----------------------------------------------------------- install -m644 -D %{name}.png %{buildroot}/%{_datadir}/icons/%{name}.png ----------------------------------------------------------- seems wrong because no package (on my system) installs icon png data under %{_datadir}/icons (not %{_datadir}/icons/hicolor/??x??/apps) and %{_datadir}/pixmaps should be okay for the directory where pixmaps data is installed. - And tips.txt is also installed. However, the source expects: (in src/wxgui/gui.cpp) ----------------------------------------------------- 1012 void FFrame::OnTipOfTheDay(wxCommandEvent&) 1013 { 1014 string tip_file = "fityk_tips.txt"; 1015 string tip_path = get_full_path_of_help_file(tip_file); ----------------------------------------------------- the tips file named "fityk_tips.txt". So: - Perhaps the installed file "/usr/share/fityk/tips.txt" is not needed and should be removed (actually /usr/share/fityk/fityk_tips.txt and /usr/share/fityk/tips.txt are the same - or you should apply a patch against src/wxgui/gui.cpp. * Documentation - "INSTALL" file is usually needed for people who want to rebuild this package by themselves and is not needed for people who want to install the package using rpm. - and please use "install -p" to keep timestamps ------------------------------------------------------------ install -m644 -D src/wxgui/tips.txt %{buildroot}/%{_datadir}/%{name}/fityk_tips.txt ------------------------------------------------------------ when you want to use "install" command. * Release number - please use integer for release number (some exceptions exist) - and you may want to use %{?dist} tag. While this is not required, it is preferable to avoid confusion. http://fedoraproject.org/wiki/Packaging/DistTag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review