https://bugzilla.redhat.com/show_bug.cgi?id=1317956 --- Comment #6 from gil cattaneo <puntogil@xxxxxxxxx> --- Issues: [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 58 files have unknown license. Detailed output of licensecheck in /home/gil/1317956-libfilezilla/licensecheck.txt The following source files are without license headers: libfilezilla-0.4.0.1/demos/events.cpp libfilezilla-0.4.0.1/demos/list.cpp libfilezilla-0.4.0.1/demos/process.cpp libfilezilla-0.4.0.1/demos/timer_fizzbuzz.cpp libfilezilla-0.4.0.1/lib/event.cpp libfilezilla-0.4.0.1/lib/event_handler.cpp libfilezilla-0.4.0.1/lib/event_loop.cpp libfilezilla-0.4.0.1/lib/file.cpp libfilezilla-0.4.0.1/lib/iputils.cpp libfilezilla-0.4.0.1/lib/libfilezilla/apply.hpp libfilezilla-0.4.0.1/lib/libfilezilla/event.hpp libfilezilla-0.4.0.1/lib/libfilezilla/event_handler.hpp libfilezilla-0.4.0.1/lib/libfilezilla/event_loop.hpp libfilezilla-0.4.0.1/lib/libfilezilla/file.hpp libfilezilla-0.4.0.1/lib/libfilezilla/glue/wx.hpp libfilezilla-0.4.0.1/lib/libfilezilla/iputils.hpp libfilezilla-0.4.0.1/lib/libfilezilla/libfilezilla.hpp libfilezilla-0.4.0.1/lib/libfilezilla/local_filesys.hpp libfilezilla-0.4.0.1/lib/libfilezilla/mutex.hpp libfilezilla-0.4.0.1/lib/libfilezilla/optional.hpp libfilezilla-0.4.0.1/lib/libfilezilla/private/defs.hpp libfilezilla-0.4.0.1/lib/libfilezilla/private/visibility.hpp libfilezilla-0.4.0.1/lib/libfilezilla/private/windows.hpp libfilezilla-0.4.0.1/lib/libfilezilla/process.hpp libfilezilla-0.4.0.1/lib/libfilezilla/recursive_remove.hpp libfilezilla-0.4.0.1/lib/libfilezilla/shared.hpp libfilezilla-0.4.0.1/lib/libfilezilla/string.hpp libfilezilla-0.4.0.1/lib/libfilezilla/thread.hpp libfilezilla-0.4.0.1/lib/libfilezilla/time.hpp libfilezilla-0.4.0.1/lib/libfilezilla/util.hpp libfilezilla-0.4.0.1/lib/libfilezilla/version.hpp libfilezilla-0.4.0.1/lib/local_filesys.cpp libfilezilla-0.4.0.1/lib/mutex.cpp libfilezilla-0.4.0.1/lib/process.cpp libfilezilla-0.4.0.1/lib/recursive_remove.cpp libfilezilla-0.4.0.1/lib/string.cpp libfilezilla-0.4.0.1/lib/thread.cpp libfilezilla-0.4.0.1/lib/time.cpp libfilezilla-0.4.0.1/lib/util.cpp libfilezilla-0.4.0.1/lib/version.cpp libfilezilla-0.4.0.1/tests/dispatch.cpp libfilezilla-0.4.0.1/tests/eventloop.cpp libfilezilla-0.4.0.1/tests/iputils.cpp libfilezilla-0.4.0.1/tests/smart_pointer.cpp libfilezilla-0.4.0.1/tests/string.cpp libfilezilla-0.4.0.1/tests/test.cpp libfilezilla-0.4.0.1/tests/test_utils.hpp libfilezilla-0.4.0.1/tests/time.cpp Please, aks to upstream to add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [?]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-root See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required Please, remove [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libfilezilla-devel , libfilezilla-debuginfo libfilezilla.i686: E: incorrect-fsf-address /usr/share/licenses/libfilezilla/COPYING https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Please, report to upstream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review