Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Crypt-Simple - Encrypt stuff simply https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243695 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-24 02:52 EST ------- Yep, that builds fine. There's not much to it, is there? Just three files, and two of them are documentation. Review: * source files match upstream: 3db6e7754eaa425ab2d958d40b62d2026b0b186cd576ee352b4c172fb52d8e17 Crypt-Simple-0.06.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Crypt::Simple) perl-Crypt-Simple = 0.06-2.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Compress::Zlib) perl(Crypt::Blowfish) perl(Digest::MD5) perl(FreezeThaw) perl(MIME::Base64) perl(strict) * %check is present and all tests pass: All tests successful. Files=6, Tests=31, 1 wallclock secs ( 0.46 cusr + 0.15 csys = 0.61 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review