[Bug 1318781] Review Request: python-pygments-markdown-lexer - A Markdown lexer for Pygments to highlight Markdown code snippets.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318781

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pingou@xxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |pingou@xxxxxxxxxxxx



--- Comment #2 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
* Spec is clean
* Builds fine on F23 (x86_64) (and koji/rawhide above)
* rpmlint is clean:

rpmlint
rpmbuild/RPMS/noarch/python2-pygments-markdown-lexer-0.1.0.dev39-1.fc23.noarch.rpm
rpmbuild/RPMS/noarch/python3-pygments-markdown-lexer-0.1.0.dev39-1.fc23.noarch.rpm
python-pygments-markdown-lexer-0.1.0.dev39-1.fc23.src.rpm
python2-pygments-markdown-lexer.noarch: W: summary-ended-with-dot C A Markdown
lexer for Pygments to highlight Markdown code snippets.
python3-pygments-markdown-lexer.noarch: W: summary-ended-with-dot C A Markdown
lexer for Pygments to highlight Markdown code snippets.
python-pygments-markdown-lexer.src: W: summary-ended-with-dot C A Markdown
lexer for Pygments to highlight Markdown code snippets.
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

! In the three files in pygments_markdown_lexer I see a mix of Apache 2 and
BSD, should we mention BSD in the license field in the spec?

! There seems to be tests upstream but not seeing them in the tarbal, maybe
something to work on w/ upstream.

The rest looks good.

If we can figure out the license question, I'll approve the package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]