https://bugzilla.redhat.com/show_bug.cgi?id=1316676 Soumya Koduri <skoduri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |skoduri@xxxxxxxxxx --- Comment #1 from Soumya Koduri <skoduri@xxxxxxxxxx> --- As per the fedora-review guidelines, one of the MUST items is that MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. Please correct your .spec file as per https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL. Other issue which were reported while using fedora-review are : Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text licencecheck.txt on running fedora-review: GPL (v2 or later) ----------------- tlog-2/include/tlog/conf_origin.h tlog-2/include/tlog/es_json_reader.h tlog-2/include/tlog/fd_json_reader.h tlog-2/include/tlog/fd_json_writer.h tlog-2/include/tlog/grc.h tlog-2/include/tlog/json_chunk.h tlog-2/include/tlog/json_dispatcher.h tlog-2/include/tlog/json_misc.h tlog-2/include/tlog/json_msg.h tlog-2/include/tlog/json_reader.h tlog-2/include/tlog/json_reader_type.h tlog-2/include/tlog/json_sink.h tlog-2/include/tlog/json_source.h tlog-2/include/tlog/json_stream.h tlog-2/include/tlog/json_writer.h tlog-2/include/tlog/json_writer_type.h tlog-2/include/tlog/mem_json_reader.h tlog-2/include/tlog/mem_json_writer.h tlog-2/include/tlog/misc.h tlog-2/include/tlog/pkt.h tlog-2/include/tlog/play_conf.h tlog-2/include/tlog/play_conf_cmd.h tlog-2/include/tlog/play_conf_validate.h tlog-2/include/tlog/rc.h tlog-2/include/tlog/rec_conf.h tlog-2/include/tlog/rec_conf_cmd.h tlog-2/include/tlog/rec_conf_validate.h tlog-2/include/tlog/sink.h tlog-2/include/tlog/sink_type.h tlog-2/include/tlog/source.h tlog-2/include/tlog/source_type.h tlog-2/include/tlog/syslog_json_writer.h tlog-2/include/tlog/syslog_misc.h tlog-2/include/tlog/test_json_sink.h tlog-2/include/tlog/test_json_source.h tlog-2/include/tlog/test_json_stream_enc.h tlog-2/include/tlog/test_misc.h tlog-2/include/tlog/trx.h tlog-2/include/tlog/trx_act.h tlog-2/include/tlog/trx_basic.h tlog-2/include/tlog/trx_frame.h tlog-2/include/tlog/trx_iface.h tlog-2/include/tlog/trx_level.h tlog-2/include/tlog/trx_state.h tlog-2/include/tlog/tty_sink.h tlog-2/include/tlog/tty_source.h tlog-2/include/tlog/utf8.h tlog-2/lib/es_json_reader.c tlog-2/lib/fd_json_reader.c tlog-2/lib/fd_json_writer.c tlog-2/lib/grc.c tlog-2/lib/json_chunk.c tlog-2/lib/json_dispatcher.c tlog-2/lib/json_misc.c tlog-2/lib/json_msg.c tlog-2/lib/json_reader.c tlog-2/lib/json_sink.c tlog-2/lib/json_source.c tlog-2/lib/json_stream.c tlog-2/lib/json_writer.c tlog-2/lib/mem_json_reader.c tlog-2/lib/mem_json_writer.c tlog-2/lib/misc.c tlog-2/lib/pkt.c tlog-2/lib/play_conf.c tlog-2/lib/rc.c tlog-2/lib/rec_conf.c tlog-2/lib/sink.c tlog-2/lib/source.c tlog-2/lib/syslog_json_writer.c tlog-2/lib/syslog_misc.c tlog-2/lib/test_json_sink.c tlog-2/lib/test_json_source.c tlog-2/lib/test_json_stream_enc.c tlog-2/lib/test_misc.c tlog-2/lib/tty_sink.c tlog-2/lib/tty_source.c tlog-2/lib/utf8.c tlog-2/ltmain.sh tlog-2/src/tlog-play.c tlog-2/src/tlog-rec.c tlog-2/src/tlog-test-fd-json-reader.c tlog-2/src/tlog-test-grc.c tlog-2/src/tlog-test-json-overlay.c tlog-2/src/tlog-test-json-passthrough.c tlog-2/src/tlog-test-json-sink.c tlog-2/src/tlog-test-json-source.c tlog-2/src/tlog-test-json-stream-btoa.c tlog-2/src/tlog-test-json-stream-enc-bin.c tlog-2/src/tlog-test-json-stream-enc-txt.c tlog-2/src/tlog-test-json-stream.c MIT/X11 (BSD like) ------------------ tlog-2/install-sh Unknown or generated -------------------- tlog-2/COPYING tlog-2/README.md tlog-2/ar-lib tlog-2/compile tlog-2/configure tlog-2/depcomp tlog-2/doc/log_format.md tlog-2/lib/play_conf_cmd.c tlog-2/lib/play_conf_validate.c tlog-2/lib/rec_conf_cmd.c tlog-2/lib/rec_conf_validate.c tlog-2/missing tlog-2/test-driver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review