[Bug 1317939] Review Request: dump1090 - Decode ADS-B messages from RTL-SDR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1317939



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
dump1090.i686: W: incoherent-version-in-changelog 20160303git85a200-4
['20160303git85aa200-4.fc25', '20160303git85aa200-4']

I think it's question of the number of digits in %shortcommit vs that in the
%changelog.

dump1090.i686: W: non-conffile-in-etc /etc/sysconfig/dump1090
You should probably add %config(noreplace) for that file in %files.

README says that the daemon does not have to run as root. It would be great to
make it so by default.
1. pick a user name
2. create the user in %pre:

getent group NAME >/dev/null 2>&1 || groupadd -r NAME 2>&1 || :
getent passwd NAME >/dev/null 2>&1 || useradd -r -l -g NAME -s /sbin/nologin -c
"..." NAME >/dev/null 2>&1 || :

3. add User=NAME in the .service file

4. There might be additional steps necessary for the user to have privileges to
access the hardware. If it is enough to add it to some group, that can be done
with "-G group" in step 2.

/etc should be written as %{_sysconfdir} in the spec file. I don't think this
makes much sense, but the guidelines require that.

I can test that the daemon starts OK, but I don't have suitable hardware, so I
can't test it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]