[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #32 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
libwcs has Summary "An implementation of the FITS World Coordinate System
standard". I think astrometry should use the similar spelling for consistency
(and abbrevs are best avoided):
Summary: Get World Coordinate System coordinates from an image

astrometry.x86_64: W: spelling-error %description -l en_US convertion ->
conversion

The main package requires the python subpackage, and the python subpackage
requires the main package. This defeats the splitting out of the python
subpackage a bit, but it's OK (for example if python3 support is added in the
future it will be useful). So nothing to change here, just taking note.

OTOH, the data package is not required by any of the other subpackages. Do
other subpackages work without the -data subpackge? I'd expect the main
subpackage to Require -data.

Calls to ldconfig are missing
[https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries].

File /usr/bin/tabmerge from install of astrometry-0.67-5.fc23.x86_64 conflicts
with file from package perl-Text-RecordParser-1.6.5-3.fc23.noarch.
That's a sign of a bigger problem. Many binaries in astrometry have very
generic names: tablist, tabmerge, tabsort, plotxy, imstat, imcopy, listhead,
liststruc, modhead, pad-file, subtable. tabmerge has to be renamed, but I think
that the other binaries with "generic" names should be renamed too. Would an
"astrometry-" or "wcs-" prefix work?

For the user it usually does not matter that executables are written in Python.
Maybe you should drop the ".py" suffixes on executables in astrometry-python2?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]