Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MogileFS-Utils - Utilities for MogileFS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245419 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-23 14:23 EST ------- I don't think you actually need any BuildRequires except for ExtUtils::MakeMaker. The build process isn't much more than just copying some files into place. I don't suppose they harm anything, however. Review: * source files match upstream: 9dc47a6cb45a6b172b7ad419886b2de8ffc6ade25241d3e230f57a99ca274464 MogileFS-Utils-2.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. ? BuildRequires are excessive but not harmful. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl-MogileFS-Utils = 2.11-1.fc8 = /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Compress::Zlib) perl(Digest::MD5) perl(Getopt::Long) perl(LWP::Simple) perl(MogileFS::Client) >= 1 perl(POSIX) perl(Pod::Usage) perl(Socket) perl(Time::HiRes) perl(constant) perl(strict) perl(warnings) * %check is present, but there's not really any test suite to run. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review