https://bugzilla.redhat.com/show_bug.cgi?id=1318359 --- Comment #7 from mulhern <amulhern@xxxxxxxxxx> --- Thanks! Regarding %check, I'm happier skipping it because: 1. I'm the upstream maintainer and I have good continuous integration. So, I know the package is well-tested upstream. 2. My tests use the hypothesis testing library which creates a whole database of tests in a .hypothesis subdirectory. I do not want to make the hypothesis testing library a BuildRequires, and I don't want to have to worry about the cleanup afterwards. 3. I can see having some small test, just to make sure that the install hasn't been a complete failure due to some dependency issue of some sort in %check. Donning my upstream-maintainer hat, I'll consider how to add that in future, for the convenience of packagers. Regarding _isa: Is it really relevant at all in this case? Regarding python-six dependency: I'm the co-maintainer of python-pyudev which is in the same position with six and just uses Reqires. So, this arrangement works OK. Regarding spec file typo: Fixed. Regarding rpm checksum: Fixed. I uploaded fixed version to prior locations. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review