https://bugzilla.redhat.com/show_bug.cgi?id=1316186 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: librosa - a |Review Request: |python package for music |python-librosa - a python |and audio analysis |package for music and audio | |analysis --- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- So my first concerns are (as Tomáš and Antonio already pointed out): 1) Upstream clearly supports both Pythons, see https://pypi.python.org/pypi/librosa (categories section). In that case, as this is a Python library, you should package both versions as subpackages of python-librosa, see https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file about an idea how to do it. 2) The shebang manipulation should be done in %prep section, because you are preparing the sources. As Tomáš pointed out, you also need to do it before %py3_build - doing it in %prep accomplishes that. 3) There is some documentation in the GitHub repository, you *should* get it in a separate Source and rebuilt it and package it in %doc. It is also a good idea to contact upstream about a possibility to include the doc and test in the source tarball, maybe post a pullrequest with such change. I would say this is definitly not a *must* thing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review