https://bugzilla.redhat.com/show_bug.cgi?id=1270357 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Quick spec review while at $DAYJOB... May not matter but I use this with one of my packages so I can paste in the full commit but use the short one in the resultant archive. %global commit caad49c0945065f4b7bfa3ccb96523e4766a9727 %global shortcommit %(c=%{commit}; echo ${c:0:7}) As much as I dislike it, and I do, unless the package guidelines have changed don't we need the checkout date in front of the "git" part of the release in YYYYMMDD format? Are you intentionally supporting f21 and below? (and later f19?) I think the conditionals can be dropped at this point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review