Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mutt https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226167 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-06-23 09:20 EST ------- This package is in very good shape! I have some comments though: * maybe you could use gpgme? * also maybe it could be nice to enable mixmailer the day it enters fedora * the lynx BuildRequires in my opinion deserves a comment * I think that htmlview would be a better Requires than webclient, that way mutt may be installed without webclient and at the same time there is more chance that an html viewer will be selected if one is installed * I am not completly convinced that it is right to have urlview shipped with mutt. In the mutt documentation it is flagged as being external. One could imagine people wanting urlview without mutt. And there could also be people wanting mutt without urlview, although I wouldn't find it abnormal if mutt depended on urlview * the second paragraph of the %description seems a bit strange to me. It seems more confusing than explaining to me, and it seems to describe mutt more or less as the default text client mail which seems a bit hard for newcommers to me -- although I don't know what alternatives exist. * Maybe /etc/Muttrc may be made %config and not %config(noreplace) since there is Muttrc.local? * The XTERM path in url_handler.sh is wrong. I don't think xterm should be a dependency of urlview, since it would imply getting in X libs which shouldn't be required in case of mutt/urlview in my opinion. * What do you think about giving as a Requires of urlview an application for all of the categories (https, http, mailto, gopher, ftp)? It is not necessarily a good idea, but maybe something to think about. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review