[Bug 1318251] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318251



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(Test::More)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Test::Time) = 0.04
      1 perl-Test-Time = 0.04-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Test-Time*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires 
FIX:
* Please add missing BRs
- perl(Module::Install::Include) - provides auto_include - Makefile.PL:43
- perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24
- perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 
* Removed BRs
- perl(Filter::Util::Call) - it is not used


TODO: Because you remove all files from repository inc, it could be done
  easily, e.g.
rm -r inc
sed -i -e '/^inc\// d' MANIFEST

In that case, the 'findutils' could be removed from BRs

TODO: You can replace %__perl macros with plain perl command.

Description is ok
TODO: Please replace ':' at the end of description with '.'

Please correct 'FIX' issue and consider fixing 'TODO' items and
provide new spec file.

The package is not approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]