https://bugzilla.redhat.com/show_bug.cgi?id=1316186 T. Orsava <torsava@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dkrejci@xxxxxxxxxx Flags| |needinfo?(dkrejci@xxxxxxxxx | |m) --- Comment #1 from T. Orsava <torsava@xxxxxxxxxx> --- Hi! So here's the review: - rpmlint says: python3-librosa.src: E: description-line-too-long C LibROSA is a python package for music and audio analysis. It provides the building blocks necessary to create music information retrieval systems. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. - start with Release number 1, not 2. - Please include all relevant files as %doc: AUTHORS, CHANGELOG, CONTRIBUTING - Try to add %check section to run tests provided by the package if possible. - rpmlint: python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/effects.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/time_frequency.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/files.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/onset.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/decorators.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/__init__.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/output.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/deprecation.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/feature/__init__.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/exceptions.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/decompose.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/display.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/audio.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/feature/utils.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/beat.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/segment.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/utils.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/version.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/__init__.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/constantq.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/feature/rhythm.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/pitch.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/core/spectrum.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/__init__.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/filters.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/util/feature_extractor.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/cache.py 644 /usr/bin/env python3-librosa.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/librosa/feature/spectral.py 644 /usr/bin/env * Suggestion: remove shebang lines (which is the first line of a file when it starts with #!) from these files as they are unnecessary since these scripts aren't executable. * For an inspiration how to do this, you can look at http://pkgs.fedoraproject.org/cgit/rpms/qutebrowser.git/tree/qutebrowser.spec lines 42-45, I'll gladly show you how it works in person. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review