https://bugzilla.redhat.com/show_bug.cgi?id=1308779 --- Comment #10 from Anoop C S <anoopcs@xxxxxxxxxx> --- (In reply to Greg Bailey from comment #8) > > licensecheck.txt on running fedora-review: > > > > Unknown or generated > > -------------------- > > git-tools-ea095192bc4180cc89d56f650deaeb0cbfe1ae25/README.md > > I'm not sure this is valid; the README.md specifies GPLv3+. Here is the reason: fedora-review tool uses licensecheck utility for checking the presence of license related terms inside source file. See line number 733 from https://git.fedorahosted.org/cgit/FedoraReview.git/tree/plugins/generic.py. And looking through sources for licensecheck utility from debian I could see that they are checking for specified lines. See the following links which proves this argument. https://github.com/Debian/devscripts/blob/master/scripts/licensecheck.pl#L623 https://github.com/Debian/devscripts/blob/master/scripts/licensecheck.pl#L656 You may need to include the following to get rid of this warning: This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. One more suggestion (sorry for not mentioning this before): Reading from rpm built it looks like git-tools is of version 0 and release 0.2 which is not correct. Would you mind changing the version to 0.1 and release to 3 in the spec file? So that it looks clean something like git-tools-0.1-3. Or even you can have version = 0.1.1 and release = 3. If you can make this change, I will give it a final round review afterwards. Otherwise it looks good. Thanks for addressing the comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review