https://bugzilla.redhat.com/show_bug.cgi?id=1310092 --- Comment #16 from Ralf Senderek <fedora@xxxxxxxxxxx> --- I have changed the source code and updated the spec file (now release 5): Spec URL: https://crypto-bone.com/fedora/cryptobone.spec SRPM URL: https://crypto-bone.com/fedora/cryptobone-1.0.1-5.fc23.src.rpm (In reply to Richard Shaw from comment #14) > I'm assuming the sudogetuser in %post creates an interactive prompt? > > Unfortunately the guidelines strictly forbid interactive installs, it's one > of the biggest differences between Fedora/Redhat and Debian philosophies. > OK, I've made the whole installation process non-interactive now! > > Also, this is probably not compliant: > > > if ! systemctl is-active sshd > /dev/null ; then > systemctl enable sshd > fi I have added a line "Requires=sshd.service" to the cryptoboned.service file and removed the code above from the spec file. > > Some other script feedback: > > Daemons are not allowed to be enabled on install unless they have been > approved to do so. You should be using the systemd macros which take care of > this for you: OK, I have resolved these issues by transferring the activation of my daemons to the source code (/usr/lib/cryptobone/sudogetuser). The spec file now has a %prosttrans section, which informs the user to run this script. This can be done any time, as long as the user has knowledge of the root password, to set the sudoers.d/cbcontrol file and to activate the deamon. Cron jobs are gone now in favour of a systemd timer, as you advised. > > Other odds-and-ends: > > # You want to use mkdir -p and always use the directory macros > mkdir $RPM_BUILD_ROOT/usr/share/icons > mkdir $RPM_BUILD_ROOT/usr/share/icons/default done. > > # I prefer %{buildroot} but either is acceptable: > mkdir -p %{buildroot}%{_datadir}/default done. > > # Is a jpg the only one available? PNG/SVGs are preferred, usually XPM is > the backup. > cp $RPM_BUILD_ROOT%{cryptobonedir}/GUI/cryptobone.jpg > $RPM_BUILD_ROOT/usr/share/icons/default I've changed that to a PNG file instead. > > # Is there a reason the desktop file needs to be executable? No, of course not, I've changed that to 0644 mode now. I hope the cryptobone package is in an acceptable shape now. Thank you for your review so far. Ralf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review