https://bugzilla.redhat.com/show_bug.cgi?id=1308779 --- Comment #6 from Anoop C S <anoopcs@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: You must have one LICENSE file in source. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. licensecheck.txt complains about two files under "Unknown or generated" section. See https://bugzilla.redhat.com/show_bug.cgi?id=1308779#c5 Can you please correct this? [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Note: See https://bugzilla.redhat.com/show_bug.cgi?id=1308779#c3 [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Note: May be you can provide all reuqires in a single line. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: See https://bugzilla.redhat.com/show_bug.cgi?id=1308779#c4. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: Please do so. [x]: Final provides and requires are sane (see below). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: See https://bugzilla.redhat.com/show_bug.cgi?id=1308779#c4 [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: git-tools-0-0.1.20160215gitea09519.fc24.noarch.rpm git-tools-0-0.1.20160215gitea09519.fc24.src.rpm git-tools.noarch: W: spelling-error %description -l en_US repos -> ropes, reps, repose git-tools.noarch: W: spelling-error %description -l en_US rebase -> rebate, debase, re base git-tools.noarch: W: spelling-error %description -l en_US mtime -> mime, time, m time git-tools.noarch: W: incoherent-version-in-changelog 0.1.20160215gitea09519 ['0-0.1.20160215gitea09519.fc24', '0-0.1.20160215gitea09519'] git-tools.noarch: W: no-manual-page-for-binary git-restore-mtime-core git-tools.noarch: W: no-manual-page-for-binary git-restore-mtime-bare git-tools.src: W: spelling-error %description -l en_US repos -> ropes, reps, repose git-tools.src: W: spelling-error %description -l en_US rebase -> rebate, debase, re base git-tools.src: W: spelling-error %description -l en_US mtime -> mime, time, m time 2 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- git-tools (rpmlib, GLIBC filtered): /bin/bash /usr/bin/env git python Provides -------- git-tools: git-tools Source checksums ---------------- https://github.com/MestreLion/git-tools/archive/ea095192bc4180cc89d56f650deaeb0cbfe1ae25.tar.gz#/git-tools-ea09519.tar.gz : CHECKSUM(SHA256) this package : 36058da7ba669beaf8fa4d301e6ba50d86a302baa5b073d3135bc04fde61f608 CHECKSUM(SHA256) upstream package : 36058da7ba669beaf8fa4d301e6ba50d86a302baa5b073d3135bc04fde61f608 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n git-tools Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review