[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305996

William Moreno <williamjmorenor@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |williamjmorenor@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |williamjmorenor@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #9 from William Moreno <williamjmorenor@xxxxxxxxx> ---
I am not sure about this packaging, but need a lot of work.

You are not going to epel6 so you do not have this in the top of your spec:

%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?__python2: %global __python2 /usr/bin/python2}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

So we have python3 in epel7:
http://mirror.us.leaseweb.net/epel/7/x86_64/p/python34-3.4.3-4.el7.x86_64.rpm

And if this is this library do not need nothing out of the python standar
library you can build for python3 in epel7.

You are not providing a python2-subpackage.

You are not using the python-provides macro.

You have build requieres python-sphinx but you are no build any documentation
in the spec, also do not provide a -doc subpackage.

You not requires but python3-sphinx and python-sphinx. 

Please look at this package spec:

http://pkgs.fedoraproject.org/cgit/rpms/python-pg8000.git/tree/python-pg8000.spec?h=master

It is up to date with current packaging guidelines and support both python3 and
python2 in Fedora 24 and 25 and also Epel7, it will not compile in Fedora23 but
you can test in koji to build in rawhide and epel7.

To get the source rpm in your F23 host just run:

rpmbuild -bs /home/user/rpmbuild/SPECS/python-pyuv.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]