https://bugzilla.redhat.com/show_bug.cgi?id=1310128 --- Comment #8 from Jan Pokorný <jpokorny@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: coreutils make gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. comment: Per http://mattmahoney.net/dc/zpaq204.pdf (p.22): > I (Matt Mahoney) am not aware of any patents protecting any of the > techniques needed to fully implement a compression or decompression > algorithm or product according to this specification. I have not > filed for patents on any of the techniques described here and will > not do so. Casual patent search haven't shown anything that would appear to document ZPAQ. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/mock/booth/zpaq/zpaq/licensecheck.txt comment: I wonder if the "combined" licenses doesn't effectively make the library being MIT licensed (you shouldn't touch it unless you agree to MIT). I know MIT is not copyleft, but when the code is directly combined, it's not the same as linking... [-]: License file installed when any subpackage combination is installed. [X]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. comment: If https://github.com/y-256/libdivsufsort (not verified whether this is the authoritative location) ever gets packaged, would be good to reconsider the in-code ("soft") bundling, at least. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. comment: Subjective opinion: in this case of "public domain except this well defined part (MIT)" provided in free form within the source files, it's not needed. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zpaq- libs , zpaq-devel comment: The note is bogus in this case, as "zpaq" RPM carries the binary using the associated library no other subpackage shall require it. -devel requires -libs in a proper way. [X]: Package functions as described. comment: Per %check. [X]: Latest version is packaged. comment: Even newer version packaged for a test [comment 2] :-) [X]: Package does not include license text files separate from upstream. [X]: Patches link to upstream bugs/comments/lists or are otherwise justified. [X]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Source checksums ---------------- http://mattmahoney.net/dc/zpaq705.zip : CHECKSUM(SHA256) this package : d8abe3e3620d4c6f3ddc1da149acffa4c24296fd9c74c9d7b62319e308b63334 CHECKSUM(SHA256) upstream package : d8abe3e3620d4c6f3ddc1da149acffa4c24296fd9c74c9d7b62319e308b63334 ===== Additional comments ===== rather important points: - https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning In cases where upstream ships unversioned .so library (so this is not needed for plugins, drivers, etc.), the packager MUST try to convince upstream to start versioning it. minor glitches up to the consideration: - zpaq.spec: group tag unnecessary [https://fedoraproject.org/wiki/packaging:guidelines#tags_and_sections] - zpaq-7.05-cast-negative-values-in-models-definiton.patch + zpaq-7.05-Silent-a-signess-ambiguity-comparison-warning.patch: s/signess/signedness/ notes: - rpmlint: zpaq-libs.x86_64: w: undefined-non-weak-symbol /usr/lib64/libzpaq.so.0.1 libzpaq::error(char const*) -- apparently a symbol to be delived by the library user -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review