[Bug 1308779] Review Request: git-tools - Assorted git-related scripts and tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1308779

Anoop C S <anoopcs@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anoopcs@xxxxxxxxxx



--- Comment #3 from Anoop C S <anoopcs@xxxxxxxxxx> ---
Hi Greg,

Initial review comments on running rpmlint against source and binary rpms.

[1] rpmlint warns about missing man pages for git-restore-mtime-bare and
git-restore-mtime-core binaries. Was that intentional? Please feel free to add
man pages in case you missed.

git-tools.noarch: W: no-manual-page-for-binary git-restore-mtime-bare
Each executable in standard binary directories should have a man page.

git-tools.noarch: W: no-manual-page-for-binary git-restore-mtime-core
Each executable in standard binary directories should have a man page.


[2] rpmlint also warns about mismatch in version from changelog entry and
created binary rpm.
git-tools.noarch: W: incoherent-version-in-changelog 0.1.20160215gitea09519
['0-0.1.20160215gitea09519.fc23', '0-0.1.20160215gitea09519']

If you need version 0.1, then you need to make the following changes in spec
file:
Version:    0.1
Release:    1.20160215gitea09519%{?dist}

and changelog entry should include 0.1-1.20160215gitea09519


I will get back with more detailed review soon over weekend.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]