[Bug 1121119] Review Request: rubygem-gyoku - Translates Ruby Hashes to XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1121119

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch@xxxxxxxxxx



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
(In reply to Jun Aruga from comment #1)
> Hi, Steve.
> Let me review it.
> 
> - Mock build was failed.
> 
>   $ mock -r fedora-rawhide-x86_64 rubygem-gyoku-1.1.1-1.fc20.src.rpm
>   ...
>   Error: nothing provides rubygem(tins) >= 1.6.0 needed by
> rubygem-coveralls-0.8.10-1.fc24.noarch
>   ...

This is actually issue of Coveralls. But it seems that the yesterdays build
(http://koji.fedoraproject.org/koji/buildinfo?buildID=743095) should fix that
issue.


Also, looking at the .spec file, I'll note here a few random tips:

Use the %license macro, drop the unnecessary conditionals, use a wildcard for
exclusion of the dot files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]