[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1313155



--- Comment #2 from Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> ---
Please note that the URL needs to be the link to the upstream project, and
Source needs to be the link to the upstream source file.

Also, remove Vendor.

You are not allowed to automatically enable services.

Why do you modify global system files (/etc/nrpe.cfg) rather than creating an
/etc/nrpe.d/whatever.cfg?

Instead of "make", use %make, so that the optflags get injected.

You need to ship a license for the sources: if it's in the tarball, install it
as %doc. If it's not, add it.


Please fix these issues first, and then I'll look further.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]