https://bugzilla.redhat.com/show_bug.cgi?id=1083962 --- Comment #26 from Honza Horak <hhorak@xxxxxxxxxx> --- There are only couple of issues, but it looks good generally. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/maxscale/COPYRIGHT See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: redhat-rpm-config See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in maxscale See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d, /var/lib/maxscale/etc ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output RPATH is actually defined in binaries and libraries (plugins) [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "LGPL (v2.1)", "Unknown or generated". 41 files have unknown license. Detailed output of licensecheck in /home/hhorak/tmp/maxscale- review/1083962-maxscale/licensecheck.txt This combination is valid. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /var/lib/maxscale/etc This should be fixed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d, /var/lib/maxscale/etc This should be fixed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. It would be better to remove bundled pcre2 from source to be sure it is not used during build. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in maxscale-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: maxscale-1.3.0-2.fc23.x86_64.rpm maxscale-debuginfo-1.3.0-2.fc23.x86_64.rpm maxscale-1.3.0-2.fc23.src.rpm maxscale.x86_64: E: explicit-lib-dependency mariadb-libs maxscale.x86_64: W: spelling-error Summary(en_US) centric -> eccentric, centrist, concentric maxscale.x86_64: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric maxscale.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged maxscale.x86_64: W: spelling-error %description -l en_US customisation -> customization, accusation maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmaxinfo.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtestfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libdebugcli.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libhintfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxscale ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/maxscale maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmysqlmon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libschemarouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtee.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liblog_manager.so.1.0.0 ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libgaleramon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxbinlogcheck ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxpasswd ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libreadwritesplit.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libshardrouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxkeys ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libHTTPD.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libMySQLBackend.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libnamedserverfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libqlafilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libreadconnroute.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libbinlogrouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtopfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtelnetd.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libMySQLClient.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libndbclustermon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libregexfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libdbfwfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libquery_classifier.so.1.0.0 ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmaxscaled.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxadmin ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libcli.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: W: dangling-symlink /var/lib/maxscale/errmsg.sys /usr/share/mariadb/english/errmsg.sys maxscale.x86_64: E: postin-without-ldconfig /usr/lib64/liblog_manager.so.1.0.0 maxscale.x86_64: E: postun-without-ldconfig /usr/lib64/liblog_manager.so.1.0.0 maxscale.x86_64: W: non-standard-uid /var/run/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/run/maxscale maxscale maxscale.x86_64: E: dir-or-file-in-var-run /var/run/maxscale maxscale.x86_64: W: non-standard-uid /var/lib/maxscale/etc/.secrets maxscale maxscale.x86_64: W: non-standard-gid /var/lib/maxscale/etc/.secrets maxscale maxscale.x86_64: W: hidden-file-or-dir /var/lib/maxscale/etc/.secrets maxscale.x86_64: E: non-readable /var/lib/maxscale/etc/.secrets 400 maxscale.x86_64: E: zero-length /var/lib/maxscale/etc/.secrets maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_monitors.pl 644 /usr/bin/perl maxscale.x86_64: W: devel-file-in-non-devel-package /usr/lib64/liblog_manager.so maxscale.x86_64: W: non-standard-uid /var/lib/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/lib/maxscale maxscale maxscale.x86_64: E: non-standard-dir-perm /var/lib/maxscale 750 maxscale.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libquery_classifier.so maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_threads.pl 644 /usr/bin/perl maxscale.x86_64: W: non-standard-uid /var/log/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/log/maxscale maxscale maxscale.x86_64: E: non-standard-dir-perm /var/log/maxscale 750 maxscale.x86_64: E: postin-without-ldconfig /usr/lib64/libquery_classifier.so.1.0.0 maxscale.x86_64: E: postun-without-ldconfig /usr/lib64/libquery_classifier.so.1.0.0 maxscale.x86_64: W: non-standard-gid /etc/maxscale.cnf maxscale maxscale.x86_64: E: non-readable /etc/maxscale.cnf 640 maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_resources.pl 644 /usr/bin/perl maxscale.x86_64: W: no-manual-page-for-binary maxkeys maxscale.x86_64: W: no-manual-page-for-binary maxpasswd maxscale.x86_64: W: no-manual-page-for-binary maxbinlogcheck maxscale.x86_64: W: no-manual-page-for-binary maxadmin maxscale.x86_64: W: percent-in-%post maxscale.x86_64: W: dangerous-command-in-%post chmod maxscale.src: W: spelling-error Summary(en_US) centric -> eccentric, centrist, concentric maxscale.src: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric maxscale.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged maxscale.src: W: spelling-error %description -l en_US customisation -> customization, accusation maxscale.src:104: W: macro-in-comment %check maxscale.src:107: W: make-check-outside-check-section # make testcore || : 3 packages and 0 specfiles checked; 46 errors, 29 warnings. Rpmlint (debuginfo) ------------------- Checking: maxscale-debuginfo-1.3.0-2.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory maxscale.x86_64: E: explicit-lib-dependency mariadb-libs maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 my_charset_bin maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mxs_log_tls maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 PSI_server maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 unknown_sqlstate maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 system_charset_info maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 bool_typelib maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 embedded_methods maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mxs_log_enabled_priorities maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 Sys_autocommit_ptr maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 sql_command_flags maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mxs_log_session_count maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 set_mysql_error maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mysql_options maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 THD::reset_for_next_command() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 free_old_query maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mysql_init maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 is_log_table_write_query(enum_sql_command) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 THD::end_statement() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 my_strdup maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 gwbuf_get_buffer_object_data maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 check_embedded_connection maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 find_type(st_typelib const*, char const*, unsigned int, bool) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 is_update_query(enum_sql_command) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mysql_close maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 Yacc_state::~Yacc_state() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 my_strndup maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 THD::clear_data_list() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 init_embedded_mysql maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 parse_sql(THD*, Parser_state*, Object_creation_ctx*, bool) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mysql_error maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 my_free maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 THD::store_globals() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 Lex_input_stream::init(THD*, char*, unsigned int) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 gwbuf_add_buffer_object maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 replace_quoted maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 Set_signal_information::clear() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mysql_errno maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 replace_literal maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 mxs_log_message maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 create_embedded_thd maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquery_classifier.so.1.0.0 alloc_query(THD*, char const*, unsigned int) maxscale.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libquery_classifier.so.1.0.0 /lib64/libm.so.6 maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libquery_classifier.so.1.0.0 ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libreadwritesplit.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libMySQLClient.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxadmin ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxbinlogcheck ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtopfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libHTTPD.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libregexfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxscale ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/maxscale maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxkeys ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libMySQLBackend.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libhintfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libqlafilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libshardrouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libgaleramon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libreadconnroute.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libcli.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_done(skygw_thread_st*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 simple_mutex_lock maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 release_lock maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_file_init(char*, char*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_message_done maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 mlist_init(mlist_st*, mlist_cursor_st**, char*, void (*)(void*), int) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_start(skygw_thread_st*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 mlist_done(mlist_st*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_file_alloc(char*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_file_close(skygw_file_st*, bool) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_message_send maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_must_exit maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 snprint_timestamp_hp(char*, unsigned long) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 get_decimal_len maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 snprint_timestamp(char*, unsigned long) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_file_free(skygw_file_st*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_message_init maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 atomic_add maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_file_write(skygw_file_st*, void*, unsigned long, bool) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 simple_mutex_done maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 get_timestamp_len_hp() maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 simple_mutex_unlock maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 simple_mutex_init maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 mlist_add_data_nomutex(mlist_st*, void*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_init(char const*, void* (*)(void*), void*) maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 acquire_lock maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_get_data maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_message_wait maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 skygw_thread_set_exitflag maxscale.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog_manager.so.1.0.0 get_timestamp_len() maxscale.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblog_manager.so.1.0.0 /lib64/libaio.so.1 maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liblog_manager.so.1.0.0 ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtelnetd.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmysqlmon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/maxpasswd ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtestfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libtee.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libdebugcli.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libndbclustermon.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libschemarouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmaxinfo.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libbinlogrouter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libnamedserverfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libmaxscaled.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/maxscale/libdbfwfilter.so ['', '/usr/lib64/maxscale'] maxscale.x86_64: E: postin-without-ldconfig /usr/lib64/libquery_classifier.so.1.0.0 maxscale.x86_64: E: postun-without-ldconfig /usr/lib64/libquery_classifier.so.1.0.0 maxscale.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libquery_classifier.so maxscale.x86_64: W: non-standard-uid /var/lib/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/lib/maxscale maxscale maxscale.x86_64: E: non-standard-dir-perm /var/lib/maxscale 750 maxscale.x86_64: W: non-standard-uid /var/lib/maxscale/etc/.secrets maxscale maxscale.x86_64: W: non-standard-gid /var/lib/maxscale/etc/.secrets maxscale maxscale.x86_64: W: hidden-file-or-dir /var/lib/maxscale/etc/.secrets maxscale.x86_64: E: non-readable /var/lib/maxscale/etc/.secrets 400 maxscale.x86_64: E: zero-length /var/lib/maxscale/etc/.secrets maxscale.x86_64: W: devel-file-in-non-devel-package /usr/lib64/liblog_manager.so maxscale.x86_64: W: dangling-symlink /var/lib/maxscale/errmsg.sys /usr/share/mariadb/english/errmsg.sys maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_resources.pl 644 /usr/bin/perl maxscale.x86_64: E: postin-without-ldconfig /usr/lib64/liblog_manager.so.1.0.0 maxscale.x86_64: E: postun-without-ldconfig /usr/lib64/liblog_manager.so.1.0.0 maxscale.x86_64: W: non-standard-uid /var/log/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/log/maxscale maxscale maxscale.x86_64: E: non-standard-dir-perm /var/log/maxscale 750 maxscale.x86_64: W: non-standard-gid /etc/maxscale.cnf maxscale maxscale.x86_64: E: non-readable /etc/maxscale.cnf 640 maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_monitors.pl 644 /usr/bin/perl maxscale.x86_64: W: non-standard-uid /var/run/maxscale maxscale maxscale.x86_64: W: non-standard-gid /var/run/maxscale maxscale maxscale.x86_64: E: dir-or-file-in-var-run /var/run/maxscale maxscale.x86_64: E: non-executable-script /usr/share/maxscale/plugins/nagios/check_maxscale_threads.pl 644 /usr/bin/perl maxscale.x86_64: W: no-manual-page-for-binary maxkeys maxscale.x86_64: W: no-manual-page-for-binary maxpasswd maxscale.x86_64: W: no-manual-page-for-binary maxbinlogcheck maxscale.x86_64: W: no-manual-page-for-binary maxadmin maxscale.x86_64: W: percent-in-%post maxscale.x86_64: W: dangerous-command-in-%post chmod 2 packages and 0 specfiles checked; 46 errors, 92 warnings. Requires -------- maxscale-debuginfo (rpmlib, GLIBC filtered): maxscale (rpmlib, GLIBC filtered): /bin/sh config(maxscale) ld-linux-x86-64.so.2()(64bit) libaio.so.1()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libedit.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) liblog_manager.so.1.0.0()(64bit) libm.so.6()(64bit) libmysqld.so.18()(64bit) libpcre.so.1()(64bit) libpcre2-8.so.0()(64bit) libpthread.so.0()(64bit) libquery_classifier.so.1.0.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) mariadb-errmsg mariadb-libs rtld(GNU_HASH) sh-utils shadow-utils systemd Provides -------- maxscale-debuginfo: maxscale-debuginfo maxscale-debuginfo(x86-64) maxscale: config(maxscale) libHTTPD.so()(64bit) libMySQLBackend.so()(64bit) libMySQLClient.so()(64bit) libbinlogrouter.so()(64bit) libcli.so()(64bit) libdbfwfilter.so()(64bit) libdebugcli.so()(64bit) libgaleramon.so()(64bit) libhintfilter.so()(64bit) liblog_manager.so.1.0.0()(64bit) libmaxinfo.so()(64bit) libmaxscaled.so()(64bit) libmysqlmon.so()(64bit) libnamedserverfilter.so()(64bit) libndbclustermon.so()(64bit) libqlafilter.so()(64bit) libquery_classifier.so.1.0.0()(64bit) libreadconnroute.so()(64bit) libreadwritesplit.so()(64bit) libregexfilter.so()(64bit) libschemarouter.so()(64bit) libshardrouter.so()(64bit) libtee.so()(64bit) libtelnetd.so()(64bit) libtestfilter.so()(64bit) libtopfilter.so()(64bit) maxscale maxscale(x86-64) Unversioned so-files -------------------- maxscale: /usr/lib64/liblog_manager.so maxscale: /usr/lib64/libquery_classifier.so maxscale: /usr/lib64/maxscale/libHTTPD.so maxscale: /usr/lib64/maxscale/libMySQLBackend.so maxscale: /usr/lib64/maxscale/libMySQLClient.so maxscale: /usr/lib64/maxscale/libbinlogrouter.so maxscale: /usr/lib64/maxscale/libcli.so maxscale: /usr/lib64/maxscale/libdbfwfilter.so maxscale: /usr/lib64/maxscale/libdebugcli.so maxscale: /usr/lib64/maxscale/libgaleramon.so maxscale: /usr/lib64/maxscale/libhintfilter.so maxscale: /usr/lib64/maxscale/libmaxinfo.so maxscale: /usr/lib64/maxscale/libmaxscaled.so maxscale: /usr/lib64/maxscale/libmysqlmon.so maxscale: /usr/lib64/maxscale/libnamedserverfilter.so maxscale: /usr/lib64/maxscale/libndbclustermon.so maxscale: /usr/lib64/maxscale/libqlafilter.so maxscale: /usr/lib64/maxscale/libreadconnroute.so maxscale: /usr/lib64/maxscale/libreadwritesplit.so maxscale: /usr/lib64/maxscale/libregexfilter.so maxscale: /usr/lib64/maxscale/libschemarouter.so maxscale: /usr/lib64/maxscale/libshardrouter.so maxscale: /usr/lib64/maxscale/libtee.so maxscale: /usr/lib64/maxscale/libtelnetd.so maxscale: /usr/lib64/maxscale/libtestfilter.so maxscale: /usr/lib64/maxscale/libtopfilter.so Source checksums ---------------- https://github.com/mariadb-corporation/MaxScale/archive/1.3.0/MaxScale-1.3.0.tar.gz : CHECKSUM(SHA256) this package : 6ee9d157d78cb963419b6eb3cca7e3f288cd2aa02c66caf98d72e3069b1d932b CHECKSUM(SHA256) upstream package : 6ee9d157d78cb963419b6eb3cca7e3f288cd2aa02c66caf98d72e3069b1d932b Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1083962 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review