Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qgis - A user friendly Open Source Geographic Information System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241403 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-22 13:31 EST ------- Created an attachment (id=157631) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=157631&action=view) mock build log of qgis 0.8.1-1 on Fedora devel i386 Some remarks * Mockbuild - Mockbuild failed on Fedora devel i386. At least cmake is missing for BR (I can't do a formal review until mockbuild passes) * cmake - For cmake, please check: http://fedoraproject.org/wiki/Packaging/cmake Especially, please make the build log more verbose. * rpm call - Interal rpm call in rpmbuild is forbidden because it is considered as dangerous due to some reason. Please change the following to the proper way. ----------------------------------------------------------- %define grass_ver %(rpm -q --queryformat %{VERSION} grass) ----------------------------------------------------------- * non-sover libraries with providing -devel subpackage. - Shipping non-sover libraries with providing -devel subpackage is unwilling because: Shipping -devel package means that the libraries %{_libdir}/*.so is allowed to be linked from other packages. So some binaries in other package may link to the libraries in this package. Then ABI of the libraries in this package may change in the future. At this time, as these libraries have no sover, rpm has no clue of whether ABI of these libraries changed, so rpm allows the upgrading of this package. However, this upgrade surely stop the other binaries linking to these libraries from working any more. * Using %{_builddir} --------------------------------------------------------- find %{_builddir}/%{name}-%{version}/doc -name '.cvsignore' -exec %{__rm} -f {} ';' --------------------------------------------------------- - %{_builddir}/%{name}-%{version} can be simply replaced with . as at this point the working directory is %{_builddir}/%{name}-%{version} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review