https://bugzilla.redhat.com/show_bug.cgi?id=1301063 Chandan Kumar <chkumar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(karlthered@gmail. |needinfo?(marcos.fermin.lob |com) |o@xxxxxxx) --- Comment #8 from Chandan Kumar <chkumar@xxxxxxxxxx> --- Hello Marcos, Thanks for updating the spec. Below is my comments: [1.] rename python-%{pypi_name}-tests to python2-%{pypi_name}-tests [2.] under %package -n python-%{pypi_name}-tests add Requires: python2-%{pypi_name} = %{version}-%{release} [3.] under %package -n python3-%{pypi_name}-tests add Requires: python3-%{pypi_name} = %{version}-%{release} [4.] Please include %check section to invoke tests like this: %check %if 0%{?with_python3} %{__python3} setup.py test rm -rf .testrepository %endif %{__python2} setup.py test [5.] under %files -n python-%{pypi_name} add this line %exclude %{python2_sitelib}/%{pypi_name}/tests and do same for python3 subpackage. Rest looks ok to me. Please update the spec. Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review