https://bugzilla.redhat.com/show_bug.cgi?id=1315370 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 17fc9ae1df51cf94aea14eb5e229b0e7737aed48a6a5ca40761ba387a2fdafc1). Ok. Summary verified from lib/List/SomeUtils.pm. Ok. Description verified from lib/List/SomeUtils.pm. Ok. License verified from lib/List/SomeUtils/PP.pm, LICENSE, dist.ini. Ok. No XS code, noarch BuildArch is Ok. inc/MyMakeMaker.pm not used. Ok. TODO: I recommend to package List::SomeUtils::XS in order to provide faster XS implementation. blib not used. Ok. IO::Handle not used. Ok. IPC::Open3 not used. Ok. Pod::Coverage::TrustPod not used. Ok. Pod::Wordlist not used. Ok. Test::Code::TidyAll not used. Ok. Test::CPAN::Changes not used. Ok. Test::CPAN::Meta::JSON not used. Ok. Test::EOL not used. Ok. Test::LeakTrace is optional. Ok. Test::Mojibake not used. Ok. Test::NoTabs not used. Ok. Test::Pod not used. Ok. Test::Pod::Coverage not used. Ok. Test::Spelling not used. Ok. Test::Synopsis not used. Ok. Test::Version not used. Ok. All tests pass. Ok. $ rpmlint perl-List-SomeUtils.spec ../SRPMS/perl-List-SomeUtils-0.51-1.fc25.src.rpm ../RPMS/noarch/perl-List-SomeUtils-0.51-1.fc25.noarch.rpm perl-List-SomeUtils.src: W: spelling-error Summary(en_US) Util -> Til, U til, Until perl-List-SomeUtils.src: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-List-SomeUtils.noarch: W: spelling-error Summary(en_US) Util -> Til, U til, Until perl-List-SomeUtils.noarch: W: spelling-error %description -l en_US Util -> Til, U til, Until 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-List-SomeUtils-0.51-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 Mar 9 13:49 /usr/share/doc/perl-List-SomeUtils -rw-r--r-- 1 root root 15165 Feb 27 16:18 /usr/share/doc/perl-List-SomeUtils/Changes -rw-r--r-- 1 root root 22873 Feb 27 16:18 /usr/share/doc/perl-List-SomeUtils/README.md drwxr-xr-x 2 root root 0 Mar 9 13:49 /usr/share/licenses/perl-List-SomeUtils -rw-r--r-- 1 root root 18403 Feb 27 16:18 /usr/share/licenses/perl-List-SomeUtils/LICENSE -rw-r--r-- 1 root root 9260 Mar 9 13:49 /usr/share/man/man3/List::SomeUtils.3pm.gz -rw-r--r-- 1 root root 1476 Mar 9 13:49 /usr/share/man/man3/List::SomeUtils::PP.3pm.gz drwxr-xr-x 2 root root 0 Mar 9 13:49 /usr/share/perl5/vendor_perl/List drwxr-xr-x 2 root root 0 Mar 9 13:49 /usr/share/perl5/vendor_perl/List/SomeUtils -rw-r--r-- 1 root root 23660 Feb 27 16:18 /usr/share/perl5/vendor_perl/List/SomeUtils.pm -rw-r--r-- 1 root root 10339 Feb 27 16:18 /usr/share/perl5/vendor_perl/List/SomeUtils/PP.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-List-SomeUtils-0.51-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 1 perl(:VERSION) >= 5.6.0 1 perl(Carp) 1 perl(Exporter::Tiny) 1 perl(Module::Implementation) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-List-SomeUtils-0.51-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(List::SomeUtils) = 0.51 1 perl(List::SomeUtils::PP) = 0.51 1 perl-List-SomeUtils = 0.51-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-List-SomeUtils-0.51-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13285091). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review