[Bug 1246790] Review Request: mdp - Minimalist password safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1246790



--- Comment #28 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
1.  SHOULD: Naming Not OK, see comment #27 (and prior discussion)


2.  MUST: %%build NOT ok, builds with -O0 and generates build-time warning:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)


this is to due to configure flag: -debug, I'd recommend you remove that.  While
we're at it, '--prefix=%{_prefix}' is superfluous too.

3. SHOULD fix %%check, you do a 'pushd ...', but never do any 'popd' (please
add one)


license: ok

sources: ok
18a26b7c9ce4aef6e0e2658e4ed19977  mdp-0.7.4.tar.gz

scriptlets: n/a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]