[Bug 1305390] Review Request: dreamchess-tools - DreamChess Tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305390

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
2. MUST add
BuildRequires: SDL_ttf-devel

otherwise,

naming: ok

license: ok

sources: ok
c46192e1b07fa437f9ba7467cde3956f 
dreamchess-tools-f8f32aa6fed41d82b4577dbce6f7eb106a9eb63e.tar.gz

3. scriptlets: NOT ok, remove needless icon scriptlets (package includes no
icons)

4.  SHOULD improve %description, really no idea what this package is for or
what it does.


APPROVED.  

(I'll leave the MUST FTBFS fix to you, since it won't build without it)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]