https://bugzilla.redhat.com/show_bug.cgi?id=1310873 greg.hellings@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rubygem-async_sinatra - A |rubygem-async_sinatra - A |Sinatra plugin to provide |Sinatra plugin for running |convenience whilst |on async webservers |performing asynchronous | |responses inside of the | |Sinatra framework running | |under async webservers | --- Comment #6 from greg.hellings@xxxxxxxxx --- (In reply to Jerry James from comment #5) > (In reply to greg.hellings from comment #4) > > This appears to be the same problem as the other two reviews. > > Yes, I wish I knew what is going on there. > > > This was generated from the gem file. I've abbreviated it more appropriately. > > That Summary is better, but now rpmlint complains: > > rubygem-async_sinatra.noarch: W: summary-ended-with-dot C A Sinatra plugin > for r > unning on async webservers. > > To make rpmlint happy, can we take the dot off the end? Also, you will need > to change the name of this bug to match the new summary prior to asking for > package creation. This is done. > > > This text is provided by upstream. Is British/American spelling differences > > an issue? I can alter it if American is expected. > > See the 2nd paragraph of > https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description Updated. > > > This is likely unnecessary, but the same as the other review. It is > > informative for conveying information related to packaging the gem, but not > > necessary important. > > Okay, I will leave it up to you. Removing this file, in order to simplify the whole process. Also should resolve the issue with the dependencies. There were additional files (in the examples set) that were also pulling in the /usr/bin/env requirement. I've cleaned those up and the dependency is now removed. > > > There's no reason it shouldn't be executable, if we're leaving it in. > > I'm going by the 3rd paragraph of > https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > > "Files marked as documentation must not cause the package to pull in more > dependencies than it would without the documentation. One simple way to > ensure this in most cases is to remove all executable permissions from files > in %_pkgdocdir." > > In this case, a documentation file is adding a dependency on /usr/bin/env. > > > I've moved the README.rdoc up to the main package and tagged it with > > %license. But where is the processed CHANGELOG.rdoc? I'm happy to remove it > > if you think it should be, but I've frequently seen those included as %doc > > files. > > The HTML version is in > /usr/share/gems/doc/async_sinatra-1.2.1/rdoc/CHANGELOG_rdoc.html. If you > think the source version is also useful, I'm fine with that; just asking the > question. I've also removed this file, since there should be no need to include the source file when a build result is available instead. New files at https://fedorapeople.org/~greghellings/rubygem-async_sinatra/rubygem-async_sinatra.spec https://fedorapeople.org/~greghellings/rubygem-async_sinatra/rubygem-async_sinatra-1.2.1-3.fc24.src.rpm --Greg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review