https://bugzilla.redhat.com/show_bug.cgi?id=1314865 --- Comment #4 from Jan Pokorný <jpokorny@xxxxxxxxxx> --- First, thanks for the very in-depth review. Really good points were raised, some will be discussed with upstream for sure. > TODO: Use plain commands instead of the macros (install instead of > %{__install}). Any particular justification (beside that in some instances, command != %{__command} as some more flags are predefined)? Was expecting the main purpose of having these macros predefined is to: - avoid using shell builtins - be independent on particular authoritative path of the binary/script (cf. /bin vs. /usr/bin) - %{__command_flag} formatted macros signal it's desired to run them like these (cf. cp -a) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review