https://bugzilla.redhat.com/show_bug.cgi?id=1315801 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Use virtual rubygem provides - In you spec file, you are using "BuildRequires: rubygem-rspec", but this would be nice to replace by "BuildRequires: rubygem(rspec)" * Simlify %prep section - First of all, it is the best to do all the custom steps you need at the end of the %prep section. In that case, you are already in the right directory and you can remove the pushd/popd stuff. - Secondly, I would suggest to move the rpmlint fixes to %install section. In this specific case, they are harmless, but it might happen that different modification will cause troubles with gem rebuild done in %build section * rpmlint fixes - I would suggest to delete the shebang ling instead of commenting it out. It might be completely harmless, but I have the feeling that it might cause some issues (but I might be totall wrong as well ;)) - It would be nice to report the fixes upstream. In case you have already reported them, please provide link, so anybody can check next time what is the status. * Bundled library - It seems that this package bundles libev. Is there any chance to use the system version of libev instead [1]? Or in the worst case provide the "bundled" virtual provide. Please resolve the issues prior we'll continue. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review