[Bug 1311752] Review Request: vrpn -The Virtual Reality Peripheral Network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1311752



--- Comment #8 from Dmitry Mikhirev <mikhirev@xxxxxxxxx> ---
> 1. Type=simple means that there's no synchronization wrt. to the daemon being ready to serve requests. So it's harder to write something that uses the daemon because it is necessary to poll for it to start. It would be much better to support Type=notify, or if that is not possible Type=forking.

It doesn't send systemd notification and it doesn't fork. Seems that it was
written to be started by hands but not by any init system. But I think that
systemd service is a good option anyway.

> 2. /etc/default/* is a horrible "standard" that should not be propagated. Since you are introducing the package to Fedora with no prior installations, now is the best time to simply kill support for that file.

There are several settings that can be specified only as command line options
(address to listen on etc.). That's why I prefer to allow setting these options
via file in /etc/default instead forcing users to use defaults.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]