[Bug 1310128] Review Request: zpaq - Incremental journaling back-up archiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1310128



--- Comment #3 from Jan Pokorný <jpokorny@xxxxxxxxxx> ---
For the moment, just a tiny nit up to your consideration:

rpmlint for zpaq-libs.x86_64:
W: unused-direct-shlib-dependency /usr/lib64/libzpaq.so.0.1 /lib64/libm.so.6

Possible solution per
https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency:

--- Makefile.orig    2016-03-07 18:13:32.293963439 +0100
+++ Makefile    2016-03-07 18:14:35.381048568 +0100
@@ -14,7 +14,7 @@
     $(CXX) -fPIC -DPIC $(CPPFLAGS) $(CXXFLAGS) -o $@ -c libzpaq.cpp

 $(SONAME): libzpaq.o
-    $(CXX) $(LDFLAGS) -shared -Wl,-soname,$(SONAME) -o $@ $<
+    $(CXX) $(LDFLAGS) -Wl,--as-needed -shared -Wl,-soname,$(SONAME) -o $@ $<

 libzpaq.so: $(SONAME)
     ln -s $(SONAME) libzpaq.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]